Skip to content

Issue #102: Use deprecated JavaConversions to maintain backward compatibility with Scala 2.11 #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 23, 2019

Conversation

olisikh
Copy link
Contributor

@olisikh olisikh commented Jun 19, 2019

JavaConversions is still in Scala 2.13, so we're safe to use it.
Tested by running functional tests with 2.11 version of Scala.

Should also fix #94

@maiflai
Copy link
Contributor

maiflai commented Jun 21, 2019

Thanks very much for this - I did wonder why this didn't break any of the existing 2.11 tests?

I'll try to take a look over the weekend, sorry for the delay.

@maiflai
Copy link
Contributor

maiflai commented Jun 22, 2019

I had a quick look at 2.13 but it seems there are some changes needed to support scoverage 1.4.0?

@olisikh
Copy link
Contributor Author

olisikh commented Jun 22, 2019

Tests didn’t fail because Scala 2.12 is still used by the plugin (default setup) even though the module source code uses 2.11.
To make plugin to fail you need to override scala for scoverage plugin to be 2.11

Plugins needs a test with scoverage built for 2.11 and Scala 2.11 (and 2.13 would be nice to have to be future-proof)

@maiflai maiflai merged commit 56f0d58 into scoverage:master Jun 23, 2019
@volkovandr
Copy link

volkovandr commented Jul 11, 2019

Now it does not work with 2.13 because scala.collection.JavaCoversions is not there any more
https://www.scala-lang.org/api/current/scala/collection/index.html

Opened #106

@maiflai
Copy link
Contributor

maiflai commented Jul 13, 2019

Yes - and upgrading to scoverage 1.4.0 requires work too.

I expect this will be easier with an upstream PR to remove the use of Seq when Array would suffice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ScoverageHtmlWriter fails with NoSuchMethodError
3 participants